-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverageProvider
to jest --init
#10044
Add coverageProvider
to jest --init
#10044
Conversation
Hi @mohamedsgap! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks! Could you add some tests as well? And an entry in the changelog 🙂 |
hey @SimenB, just updated this PR with some tests and add entry to changelog, buy i don't know that some checks did't pass! |
Hi @mohamedsgap , you also need to modify some things in |
coverageProvider
to jest --init
prompts coverageProvider
to jest --init
prompts
There's a failing test, mind taking a look? |
coverageProvider
to jest --init
prompts coverageProvider
to jest --init
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Created This PR to resolve this issue #10015, to add 'coverageProvider' to 'jest --init' prompts
Summary
We need to encourage folks try out the V8 based code coverage, so the prompt in "--init" and its entry into the generated config file would be help.